-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated shards ui for shards select modal #1138
Merged
Merged
+104
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage reportSummary
Tests which was executed
Coverage by files (43%)
|
Jest Unit tests resultsDuration: 230.181 seconds
Outcome: Passed | Total Tests: 369 | Passed: 365 | Failed: 0
|
Asmadek
requested changes
Oct 11, 2023
@egor0798 sorry but Figma file was updated and address should be shortened in the middle |
tuul-wq
approved these changes
Oct 11, 2023
Asmadek
approved these changes
Oct 12, 2023
egor0798
added a commit
that referenced
this pull request
Oct 24, 2023
* feat: refactor wallet types * feat: add keyType and type * feat: removed Identicon signingType * feat: wallet refactoring * feat: wallet refactoring finish * fix: ts check * chore: merge fiat * feat: tests, app start * chore: update linter * fix: singleshard for multisig, watch matrix isLoggedIn * feat: updated shards ui for shards select modal (#1138) * feat: updated shards ui for shards select modal * feat: added accordion for chain * feat: updated address truncate for selectable shard --------- Co-authored-by: Egor B <[email protected]> * Feat: wallet icon (#1139) * feat: added new wallet icons * feat: added nove wallet * feat: compressed icon, fixed pr comments * chore: moved wallet style conts to WalletIcon component * chore: fixed linter err --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * Feat: transfer confirm update (#1143) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test --------- Co-authored-by: Egor B <[email protected]> * feat: recieve asset modal style update (#1150) Co-authored-by: Egor B <[email protected]> * Feat: select signatory update (#1141) * feat: added new wallet icons * feat: added nove wallet * feat: updated UI for select signatory popup * feat: added support for multishard signatory * chore: pr comments fix * chore: deleted unused file * chore: pr comments fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> * Feat: notifications and log update (#1149) * feat: updated notifications and log modal * chore: pr comments update --------- Co-authored-by: Egor B <[email protected]> * Feat: operation details update (#1146) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test * feat: operation wallets update * feat: updated signatory card * chore: rename wallet card component * chore: moved component to ui/cards --------- Co-authored-by: Egor B <[email protected]> * Feat: staking update (#1148) * feat: select validators and selected validators update * feat: table align fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> * Feat: Multisig confirm update (#1155) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test * feat: operation wallets update * feat: updated signatory card * feat: multisig operation confirmation update * chore: comment update * chore: padding fixes * chore: commented xcmFee for multisig confirm * feat: added proper asset for xcm fee * chore: pr comments fix * chore: pr comment fix --------- Co-authored-by: Egor B <[email protected]> * fix: errors fix * fix: no signatory when delete wallet (#1160) Co-authored-by: Egor B <[email protected]> * Feat: Icons cleanup (#1163) * feat: removed unsuded icons, deleted walletTypesNew * chore: linter errors fix --------- Co-authored-by: Egor B <[email protected]> * chore: removed old component * fix: moved sign button to confirm component (#1162) * fix: moved sign button to confirm component * chore: linter errors fix * chore: localisation fix --------- Co-authored-by: Egor B <[email protected]> * Fix: wallet cleanup bugs (#1167) * fix: deleted old validators modal for staking overview page * fix: nova wallet receive screen fix * fix: notifications deleted account bug * fix: fixed validators loading state and horizonntal scroll * chore: fixed pr comments * chore: fixed validators modal test --------- Co-authored-by: Egor B <[email protected]> * fix: operations page crush (#1168) Co-authored-by: Egor B <[email protected]> * Feat: signing screen update (#1164) * feat: updated signing screen styles * chore: fixed pr comments --------- Co-authored-by: Egor B <[email protected]> * Fix: Operation details crush (#1173) * fix: operation details crush * fix: hide validators on details when there is no validators --------- Co-authored-by: Egor B <[email protected]> * fix: changed reject button display condition (#1175) Co-authored-by: Egor B <[email protected]> * Fix: wallet display on log screen (#1172) * fix: wallet display on log screen fix * fix: changed valida signatory type * chore: pr comments fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Egor B <[email protected]>
egor0798
added a commit
that referenced
this pull request
Oct 24, 2023
* feat: refactor wallet types * feat: add keyType and type * feat: removed Identicon signingType * feat: wallet refactoring * feat: wallet refactoring finish * fix: ts check * chore: merge fiat * feat: tests, app start * chore: update linter * fix: singleshard for multisig, watch matrix isLoggedIn * feat: updated shards ui for shards select modal (#1138) * feat: updated shards ui for shards select modal * feat: added accordion for chain * feat: updated address truncate for selectable shard --------- Co-authored-by: Egor B <[email protected]> * Feat: wallet icon (#1139) * feat: added new wallet icons * feat: added nove wallet * feat: compressed icon, fixed pr comments * chore: moved wallet style conts to WalletIcon component * chore: fixed linter err --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * Feat: transfer confirm update (#1143) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test --------- Co-authored-by: Egor B <[email protected]> * feat: recieve asset modal style update (#1150) Co-authored-by: Egor B <[email protected]> * Feat: select signatory update (#1141) * feat: added new wallet icons * feat: added nove wallet * feat: updated UI for select signatory popup * feat: added support for multishard signatory * chore: pr comments fix * chore: deleted unused file * chore: pr comments fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> * Feat: notifications and log update (#1149) * feat: updated notifications and log modal * chore: pr comments update --------- Co-authored-by: Egor B <[email protected]> * Feat: operation details update (#1146) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test * feat: operation wallets update * feat: updated signatory card * chore: rename wallet card component * chore: moved component to ui/cards --------- Co-authored-by: Egor B <[email protected]> * Feat: staking update (#1148) * feat: select validators and selected validators update * feat: table align fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> * Feat: Multisig confirm update (#1155) * feat: transfer confitm screen update * feat: changed transfer modal paddings * chore: updated AccountAddress test * feat: operation wallets update * feat: updated signatory card * feat: multisig operation confirmation update * chore: comment update * chore: padding fixes * chore: commented xcmFee for multisig confirm * feat: added proper asset for xcm fee * chore: pr comments fix * chore: pr comment fix --------- Co-authored-by: Egor B <[email protected]> * fix: errors fix * fix: no signatory when delete wallet (#1160) Co-authored-by: Egor B <[email protected]> * Feat: Icons cleanup (#1163) * feat: removed unsuded icons, deleted walletTypesNew * chore: linter errors fix --------- Co-authored-by: Egor B <[email protected]> * chore: removed old component * fix: moved sign button to confirm component (#1162) * fix: moved sign button to confirm component * chore: linter errors fix * chore: localisation fix --------- Co-authored-by: Egor B <[email protected]> * Fix: wallet cleanup bugs (#1167) * fix: deleted old validators modal for staking overview page * fix: nova wallet receive screen fix * fix: notifications deleted account bug * fix: fixed validators loading state and horizonntal scroll * chore: fixed pr comments * chore: fixed validators modal test --------- Co-authored-by: Egor B <[email protected]> * fix: operations page crush (#1168) Co-authored-by: Egor B <[email protected]> * Feat: signing screen update (#1164) * feat: updated signing screen styles * chore: fixed pr comments --------- Co-authored-by: Egor B <[email protected]> * Fix: Operation details crush (#1173) * fix: operation details crush * fix: hide validators on details when there is no validators --------- Co-authored-by: Egor B <[email protected]> * fix: changed reject button display condition (#1175) Co-authored-by: Egor B <[email protected]> * Fix: wallet display on log screen (#1172) * fix: wallet display on log screen fix * fix: changed valida signatory type * chore: pr comments fix * chore: pr comments fix --------- Co-authored-by: Egor B <[email protected]> * fix: empty signatory list when creating multisig transfer --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Egor B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select shards modal UI update:
Figma